Use preinstalled vcpkg on Azure#2928
Merged
taketwo merged 1 commit intoPointCloudLibrary:masterfrom Mar 16, 2019
Merged
Conversation
SergioRAgostinho
approved these changes
Mar 16, 2019
Member
That would be nice! 👍 |
Contributor
I was unaware of this as well. Good to know! The pre-installed boost version is the same as the vcpkg's one and hence it should be just fine 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our Windows CI jobs have been failing for a day or so on the "Free Up Space" step. I did not investigate what exactly was the problem, but this commit fixes it.
Closes #2832.
While working on this I dropped installation of Boost through vcpkg to accelerate debugging of the job. To my surprise, at some point the overall job has passed. Apparently, there is Boost 1.69 already installed in the images! Thus I propose to switch to using this preinstalled Boost and not install it through vcpkg. This will save us ~20 minutes of CI time. Does anyone of our vcpkg gurus (@UnaNancyOwen, @jasjuang, @claudiofantacci) have an opinion on this? Can there be any downsides?