Conversation
Notiphiliac
approved these changes
Nov 16, 2025
Notiphiliac
left a comment
Collaborator
There was a problem hiding this comment.
Works fine and I don't notice any longer loading times. Looks good to me.
Kamiikaze
reviewed
Nov 16, 2025
Kamiikaze
left a comment
Collaborator
There was a problem hiding this comment.
Looking good. But why choosing this image hoster?
What about hosting it inside the repo?
Collaborator
|
Hosting it inside the repo would make it under the same MIT license/make his image open source. He wants ownership of his own image. That image host is one of the few that are supported by Vencord which allows use as a CDN. |
Kamiikaze
approved these changes
Nov 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Light mode wallpaper has been sitting in my files for the last five years, untouched. It's not really "new" but I figured since I'm first gonna be changing image host, I should get it uploaded.
Both images are lossless WebP, because it's more efficient than PNG. For some reason, the light version is way bigger than the dark version, even though both have roughly the same amount of unique colors. Beats me why.
Since this change is going to affect all future users, I want to get this looked at before I merge. In particular, I wonder about performance and loading times. If it's not too different on the reviewers' machines from the existing stuff, I'll merge it. If there's a sudden several second gap of no image, then I have to go back to the drawing board; maybe literally.
This fixes #106 and #109.