Skip to content
This repository was archived by the owner on Aug 21, 2023. It is now read-only.

Sync upstream#14

Merged
nir-schleyen merged 2 commits intomainfrom
nirsch/syncupstream
Aug 15, 2023
Merged

Sync upstream#14
nir-schleyen merged 2 commits intomainfrom
nirsch/syncupstream

Conversation

@nir-schleyen
Copy link

Motivation and Context

Description

Contribution Checklist

SergeyMenshykh and others added 2 commits August 15, 2023 15:22
…validResponseException exceptions by SKException (microsoft#2362)

### Motivation and Context
This PR is one of the follow-up PRs aimed at gradually replacing SK
custom exceptions with SKException to provide a simple, consistent, and
extensible exception model. You can find more details in the
[ADR](https://github.com/microsoft/semantic-kernel/blob/main/docs/decisions/0004-error-handling.md)
discussing error handling.

### Description
This PR updates a few SK components to throw SKException instead of
KernelException and OpenAIInvalidResponseException, and removes those
exceptions.

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [x] The code builds clean without any errors or warnings
- [x] The PR follows the [SK Contribution
Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [x] All unit tests pass, and I have added new tests where possible
- [x] I didn't break anyone 😄

---------

Co-authored-by: Roger Barreto <19890735+RogerBarreto@users.noreply.github.com>
Co-authored-by: Dmytro Struk <13853051+dmytrostruk@users.noreply.github.com>
Co-authored-by: Shawn Callegari <36091529+shawncal@users.noreply.github.com>
@nir-schleyen nir-schleyen merged commit 302a3e0 into main Aug 15, 2023
@nir-schleyen nir-schleyen deleted the nirsch/syncupstream branch August 15, 2023 23:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants