feat: distinguish expansions (external or internal) (fixes #945) #953
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
external: located in the `expansions` folder internal: registered by a plugin
4 tasks
Starmism
approved these changes
Apr 5, 2023
Collaborator
|
Would it be possible to expose the boolean in some way for internal use? It would allow us to check if the expansion is internal or external for stuff like checking for Updates on the ecloud (Avoiding false positives) Or we could expose it publicly as a getter somehow ( |
Andre601
reviewed
Apr 8, 2023
src/main/java/me/clip/placeholderapi/expansion/manager/LocalExpansionManager.java
Outdated
Show resolved
Hide resolved
Collaborator
|
Line 304 in LocalExpansionManager should have a |
If an internal expansion has the same identifier as an expansion that's published to the eCloud, PAPI will always show that an update is available.
Member
Author
Done |
Andre601
approved these changes
Jul 8, 2023
BlitzOffline
approved these changes
Jul 21, 2023
PiggyPiglet
approved these changes
Jul 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
external: located in the
expansionsfolderinternal: registered by a plugin
Pull Request
Type
Description
Closes N/A