feat: fetch all expansions #952
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and display a different message if the expansion that the player is trying to download is not verified and `cloud_allow_unverified_expansions` is false
BlitzOffline
reviewed
Apr 5, 2023
src/main/java/me/clip/placeholderapi/commands/impl/cloud/CommandECloudDownload.java
Outdated
Show resolved
Hide resolved
Andre601
approved these changes
Apr 5, 2023
Starmism
approved these changes
Apr 5, 2023
BlitzOffline
approved these changes
Apr 22, 2023
Member
|
Suggest using https://placeholderapi.com/ecloud as the url so we can redirect if needed in the future |
Member
Author
Looks like the redirect is not setup right, |
BlitzOffline
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fetch all expansions and display a different message if the expansion that the player is trying to download is not verified and
cloud_allow_unverified_expansionsis falsePull Request
Type
Description
Closes N/A