Skip to content

Fix inconsistent parsing command behaviour #873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
PiggyPiglet merged 1 commit into from
Feb 23, 2023
Merged

Fix inconsistent parsing command behaviour #873

PiggyPiglet merged 1 commit into from
Feb 23, 2023

Conversation

@Andre601
Copy link
Collaborator

@Andre601 Andre601 commented Aug 14, 2022

Pull Request

Type

  • Internal change (Doesn't affect end-user).
  • External change (Does affect end-user).
  • Wiki (Changes towards the Wiki).
  • Other: __________

Description

Closes #872

Makes the parsing command more consistent by simply not parsing colors and sending the results either through CommandSender#sendMessage(String) or Bukkit.broadcastMessage(String)

@Andre601 Andre601 added Target: Code This issue/PR is targeting the Code of PlaceholderAPI Type: Bugfix This fixes an existing bug in PlaceholderAPI. labels Aug 14, 2022
@Andre601 Andre601 mentioned this pull request Aug 14, 2022
Closed
4 tasks
@iGabyTM iGabyTM self-requested a review February 23, 2023 11:28
@PiggyPiglet PiggyPiglet merged commit 9ee4afa into master Feb 23, 2023
@Andre601 Andre601 deleted the fix/872-fix-inxonsisten-parsing branch February 23, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PiggyPiglet PiggyPiglet PiggyPiglet approved these changes

@iGabyTM iGabyTM iGabyTM approved these changes

@darbyjack darbyjack Awaiting requested review from darbyjack darbyjack is a code owner

Assignees

No one assigned

Labels

Target: Code This issue/PR is targeting the Code of PlaceholderAPI Type: Bugfix This fixes an existing bug in PlaceholderAPI.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Colors inconsistently parsed inside the parse commands.

4 participants

@Andre601 @PiggyPiglet @iGabyTM