Skip to content

Conversation

@Andre601
Copy link
Collaborator

@Andre601 Andre601 commented Feb 5, 2022

Pull Request

Type

  • Internal change (Doesn't affect end-user).
  • External change (Does affect end-user).
  • Wiki (Changes towards the Wiki).
  • Other: __________

Description

This PR adds a --null command argument to the parse command, which can be used instead of the player name.
Providing this argument would parse the placeholders against a null player, which can be useful for Placeholders that do not require a online player to be used.

This PR also updates all toLowerCase() to toLowerCase(Locale.ROOT) to avoid possible issues where characters will be changed to non UTF-8 characters or smth (Idk the details but it's a good change for sure.)

Closes #798

@Andre601 Andre601 added Type: Enhancement New feature or request Target: Code This issue/PR is targeting the Code of PlaceholderAPI labels Feb 5, 2022
@Andre601 Andre601 added Type: New Feature A new feature for PlaceholderAPI and removed Type: Enhancement New feature or request labels Feb 5, 2022
Copy link

@HexedHero HexedHero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Been using this and works fine

@iGabyTM iGabyTM merged commit 7afb8ee into master Feb 22, 2022
@iGabyTM iGabyTM deleted the feature/null-parse-option branch February 22, 2022 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Target: Code This issue/PR is targeting the Code of PlaceholderAPI Type: New Feature A new feature for PlaceholderAPI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Suggestion: /papi parse null

4 participants