PR to correct branch. #571
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated listing for Clans [Free] and Clans [Pro] Listings. Both plugins are utilizing the API and are available on spigot as i type this.
Updated listing for Clans [Free] and Clans [Pro] Listings. Both plugins are utilizing the API and are available on spigot as i type this.
Andre601
requested changes
Feb 14, 2021
Collaborator
Andre601
left a comment
There was a problem hiding this comment.
Not bad.
Only requires some minor changes to be mergable.
Contributor
Author
|
Changes have been made |
Andre601
approved these changes
Feb 14, 2021
Collaborator
Andre601
left a comment
There was a problem hiding this comment.
LGTM
Thanks for your contributions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Type
Description
Ill say it again, still learning PR stuff. I did not read the last comment because i never was notified of it, i had to goto my email where i then saw a notification for it. This should be targeted towards the correct branch now. The PR represents changes i made to my 2 plugin listings.
Closes N/A