Skip to content

Conversation

@Andre601
Copy link
Collaborator

Pull Request

Type

  • Internal change (Doesn't affect end-user).
  • External change (Does affect end-user).
  • Wiki (Changes towards the Wiki).
  • Other: __________

Description

Closes #527

Improves the resolvePlayer(String) method by only checking if the player played before when the player was null for getPlayer and therefore a OfflinePlayer needs to be retrieved.
If the getPlayer method doesn't return null will the retrieved entity just be returned as it should be a valid online player to use.
Why was this stupid hasPlayedBefore check even made at the very end?

@PiggyPiglet PiggyPiglet merged commit 26fdedd into master Jan 3, 2021
@Andre601 Andre601 deleted the fix/527-improve-parse-command branch April 12, 2021 14:05
@Andre601 Andre601 added this to the 2.11.0 milestone May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PAPI still fails to find player(s) on their first join

3 participants