Fix resolvePlayer method #529
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Type
Description
Closes #527
Improves the
resolvePlayer(String)method by only checking if the player played before when the player was null forgetPlayerand therefore a OfflinePlayer needs to be retrieved.If the
getPlayermethod doesn't return null will the retrieved entity just be returned as it should be a valid online player to use.Why was this stupid
hasPlayedBeforecheck even made at the very end?