Added missing NotNull annotations to setBracketPlaceholders methods #1000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etPlaceholders(Player, List)
…cketPlaceholders(Player, String)
…parameter List's type parameter (is that proper English?)
|
pull request 1000 hmm |
iGabyTM
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Type
Description
This adds missing NotNull annotations to three setBracketPlaceholders methods. As they all internally just call methods which already are annotated with NotNull for both the return value and the parameters, it's safe to add the annotations to these methods too.
(In fact I was kinda surprised when those annotations were missing, so I looked at the source to confirm the annotations are just missing instead of being absent on purpose)