Warn when exporting to a flat format#910
Conversation
This was done so that it would prompt if a user was working on an already saved flat file format, then added layers and saved again
|
One thing you could do is adding your change to And great idea, by the way |
Sure thing! |
| } | ||
|
|
||
| // If the format doesn't support layers, ask to flatten the image | ||
| if (!format.SupportsLayers && document.Layers.Count() > 1) |
There was a problem hiding this comment.
Having this prompt always show up if there are multiple layers might be too annoying / confusing for common cases where users just want to save to a .png / jpeg and don't care about preserving layers.
I think limiting it to only appearing if the previous file type did support layers (e.g. .ora) would probably be a safer starting point
There was a problem hiding this comment.
i agree prompting might be a bit excessive in that case.
Should we still execute the flatten action though?
There was a problem hiding this comment.
In that case I'd probably skip the flatten action and just do it implicitly, so the behaviour is unchanged for the common case
|
Looks good! Could you just fix the formatting issues that are causing the CI build to fail? Running |
|
@Matthieu-LAURENT39 in order for the errors to disappear, you could try checking the indentation and checking that the line endings are consistent (that is, no mixing |
done!
i tried to change it, but i'm pretty sure it was already all LF. Git didn't detect any changes that i could commit at least. |
This fixes #909
Note that this is my first time using C# and GTK, so the code quality might be subpar.
Don't hesitate to point me in the right direction and ask for changes.