Ported 'vignette' effect from old version of Paint.NET#881
Conversation
This reverts commit 58aecec.
|
|
||
| namespace Pinta.Effects; | ||
|
|
||
| internal static class SrgbUtility |
There was a problem hiding this comment.
For organization, perhaps this should go under the Utilities folder rather than Effects?
| [Caption ("Center Offset")] | ||
| public PointI CenterOffset { get; set; } | ||
|
|
||
| [MinimumValue (10), MaximumValue (400)] |
There was a problem hiding this comment.
Similar to the other PR, this should use the matching label that we decide on
| public sealed class VignetteData : EffectData | ||
| { | ||
| [Caption ("Center Offset")] | ||
| public PointI CenterOffset { get; set; } |
There was a problem hiding this comment.
I'd probably just label this "Offset" to match most other effects.
| [Caption ("Radius (as a percentage)")] | ||
| public int RadiusFactor { get; set; } = 50; | ||
|
|
||
| [MinimumValue (0), MaximumValue (1)] |
There was a problem hiding this comment.
Should this also be a percentage for consistency with the radius parameter?
|
@cameronwhite I implemented your suggestions 👍 |
|
The 'codespell' build is failing but from the error messages (and the fact that all other builds are successful, and that it failed even after I reverted the changes) I don't think it's related to my changes. |
|
Yeah it looks like some intermittent build failure - I rescheduled the build and it's working now |
https://github.com/rivy/OpenPDN/blob/cca476b0df2a2f70996e6b9486ec45327631568c/src/Effects/VignetteEffect.cs