Fix how the layer list updates its widgets#1976
Merged
Merged
Conversation
Previously the list items were entirely rebuilt in order to update the UI. This was the root cause of the crash in the referenced bug report, because updating the current layer after a right click could finalize tools and rebuild the widgets (causing the popover menu to be attached to a widget that was about to be removed) - Add an event to signal that the layer item has changed, allowing the widget to update itself. Using GObject properties and bindings is the "proper" way to update the widget, but currently we can't add properties for a managed subclass - Avoid unnecessary calls to SetCurrentUserLayer if our layer is already current. This avoids some extra updates from selection change events. Bug: #1940
Contributor
|
The GirCore bug to add properties to a subclass is gircore/gir.core#1433. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the list items were entirely rebuilt in order to update the UI. This was the root cause of the crash in the referenced bug report, because updating the current layer after a right click could finalize tools and rebuild the widgets (causing the popover menu to be attached to a widget that was about to be removed)
Add an event to signal that the layer item has changed, allowing the widget to update itself. Using GObject properties and bindings is the "proper" way to update the widget, but currently we can't add properties for a managed subclass
Avoid unnecessary calls to SetCurrentUserLayer if our layer is already current. This avoids some extra updates from selection change events.
Bug: #1940