Ensure the GTK / libadwaita language is consistent with Pinta#1877
Merged
Conversation
Member
Author
|
This worked locally when I built the mac installer on my system, but not when using the installer from the CI build. |
This was mainly an issue on macOS where the system language setting is picked up correctly by dotnet (setting the current UI culture), but the GTK / libadwaita translations from the native gettext library were still in English This change also works toward having a preference to override the default language (#1417) Fixes: #1727
This works around issues with relocating the libadwaita dll into the .app package. Also updated the build script to allow disabling code signing for easier local testing
59f75d5 to
0c2cb62
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was mainly an issue on macOS where the system language setting is picked up correctly by dotnet (setting the current UI culture), but the GTK / libadwaita translations from the native gettext library were still in English
This change also works toward having a preference to override the default language (#1417)
Fixes: #1727