make the "splatter" brush continue to draw without mouse movement#1817
Conversation
…ontinue to draw when mouse is kept in one position
|
Thanks for looking at this! I'd prefer to keep the BasePaintBrush API as simple as possible (e.g. just a flag to indicate that a brush type wants continuous mouse events, or perhaps a control for the time interval) For the timer, using |
|
Hi, thanks for the feedback. I reorganized the code according to your suggestions; I hope I understood correctly what you meant. |
cameronwhite
left a comment
There was a problem hiding this comment.
Thanks! This is more along the lines of what I had in mind, but I left a few comments about ideas to simplify things further
cameronwhite
left a comment
There was a problem hiding this comment.
Thanks for the changes! I just have one last fix to suggest, noted in the comments, but otherwise this looks good to merge 👍
The format check on the CI builds is also failing - I think you should be able to run dotnet format to fix that, but if that's not easy for you to run in your environment I can run it myself before merging
I can run, and did now run, |
The formatting check seems good now, so I guess your change also removed whatever the formatting error was 👍 Otherwise, |
Pinta until now behaved differently from other painting software in that the "splatter" brush required mouse movement in order to continue to draw. This makes sense for the other brushes, but not this one, because you might want a denser "spray" in one position than in others.
This PR makes Pinta behave the way MS Paint or KolourPaint do.