Making floating-point calculations consistent across platforms - Round 1#1668
Making floating-point calculations consistent across platforms - Round 1#1668cameronwhite merged 4 commits into
Conversation
|
When I removed the |
|
Just by replacing the Mandelbrot1 image, the tests succeeded in all platforms, even without the configuration file. I think the wrong image was being used for the tests. But how was the previous image generated in the first place? Anyway, this mergeable progress is a byproduct of our discovery. For that reason I will now rename this pull request to specify that it is "Round 1" and I will open it for review. In the next 'round' I will address the following: |
|
Thanks for investigating! The output file probably hadn't been updated in a while since the test was ignored (or maybe it was generated incorrectly originally), so it's possible that the differences were fixed / avoided by some changes in the meantime |
A Mandelbrot test is annotated with
Ignorebecause the generated image is slightly different across platforms "for unknown reasons". Could it just be that "native" floating-point operations give different results depending on the processor architecture, and it could be fixed by making them consistent, even if the calculations are less optimized?I don't currently have any way to test Pinta locally on an ARM processor, so I will open this pull request and do the following:
Ignoreattribute. I would expect the tests (running as part of the build) to fail