Add a flag to prevent infinite loop if changing layers adds a history item#1660
Merged
Conversation
… item When a history item is added, the list view is rebuilt and the selection is reset back to its original value. When this happens, we don't need to trigger another change to the document's active layer since the selection won't be any different. This previously led to an infinite loop because the current tool is committed before updating the document's active layer. Fixes: #1463
Contributor
|
@cameronwhite Could this be backported to 3.0.6? I did some quick testing and it seems to work fine (I patched the fix on top of 3.0.5). |
Member
Author
|
I'm hoping to instead just get 3.1 ready to release :) (pushing some remaining tasks to 3.2 if necessary) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a history item is added, the list view is rebuilt and the selection is reset back to its original value. When this happens, we don't need to trigger another change to the document's active layer since the selection won't be any different. This previously led to an infinite loop because the current tool is committed before updating the document's active layer.
Fixes: #1463