Skip to content

Dialog in StatusBarColorPaletteWidget being handled asynchronously#1382

Merged
cameronwhite merged 3 commits into
PintaProject:masterfrom
Lehonti:improvement1
Apr 25, 2025
Merged

Dialog in StatusBarColorPaletteWidget being handled asynchronously#1382
cameronwhite merged 3 commits into
PintaProject:masterfrom
Lehonti:improvement1

Conversation

@Lehonti

@Lehonti Lehonti commented Apr 22, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@cameronwhite

Copy link
Copy Markdown
Member

I think this is unrelated to your change, but noticed it while testing and might be easy to fix at the same time - cancelling the color picker dialog still ends up changing the primary color

Screen.Recording.2025-04-23.at.11.48.59.PM.mp4

@Lehonti

Lehonti commented Apr 24, 2025

Copy link
Copy Markdown
Contributor Author

Thanks @cameronwhite for pointing out this bug. I tried to solve it and thought it would be easy, but as you can see from the reversal of the second commit (where, for some reason, one can't even change the colors), it's a bit tricky. I think it might deserve its own pull request, unless you have some idea of what it could be.

@cameronwhite

Copy link
Copy Markdown
Member

Agreed, this does seem more involved than I thought, since the color picker can update the palette live while it's open (you can leave it open while doing other changes on the canvas). So I think this is better as a separate issue to fix

@cameronwhite cameronwhite merged commit fed6de8 into PintaProject:master Apr 25, 2025
@Lehonti Lehonti deleted the improvement1 branch April 25, 2025 08:13
@Lehonti Lehonti mentioned this pull request May 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants