Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the
Comment |
🚀 Pre-release Build ReadyTest builds are ready! Install directly using the # Install the pre-release
bin install https://github.com/PinePeakDigital/buzz/releases/tag/pr-222-latest buzz-pr-222# Run the pre-release
buzz-pr-222# Uninstall the pre-release
bin remove buzz-pr-222Direct Download LinksOr download binaries directly from the pre-release page:
|
There was a problem hiding this comment.
Pull request overview
This PR updates the buzz schedule timeline so that wrapping is based on the actual terminal width instead of the COLUMNS environment variable, improving behavior across more environments and handling non-TTY output correctly.
Changes:
- Replace
COLUMNSenvironment-variable-based width detection indisplayTimelinewithterm.IsTerminal+term.GetSizefor syscall-based terminal width detection. - Ensure piped/non-interactive output falls back to a default width of 80 when stdout is not a terminal.
- Promote
github.com/charmbracelet/x/termto a direct dependency ingo.modto support the new terminal width logic.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| main.go | Switches timeline width calculation from COLUMNS env lookup to term.IsTerminal + term.GetSize so wrapping reflects real terminal size, while retaining an 80‑column fallback. |
| go.mod | Adds github.com/charmbracelet/x/term as a direct dependency, supporting the new terminal width detection logic. |
…ping Co-authored-by: narthur <4655422+narthur@users.noreply.github.com>
Co-authored-by: narthur <4655422+narthur@users.noreply.github.com>
b8163ed to
8b789d6
Compare
The
buzz scheduletimeline output relied on theCOLUMNSenvironment variable for width detection. Most terminals don't setCOLUMNS, causing the output to always default to 80 characters.Changes
os.LookupEnv("COLUMNS")withterm.GetSize()syscall for actual terminal widthterm.IsTerminal()check to handle piped output correctlygithub.com/charmbracelet/x/termfrom indirect to direct dependencyImplementation
Timeline output now wraps correctly based on actual terminal dimensions across all environments.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
go.googlesource.com/update-job-proxy /update-job-proxy /home/REDACTED/work/_temp/runtime-logs/mkcert/rootCA.pem --updater-env NODE_EXTRA_CA_CERTS=/usr/local/share/ca-certificates/dbot-ca.crt -plu�� /usr/libexec/gcc/x86_64-linux-gnu/13/liblto_plugin.so -plugin-opt=/usr/libexec/gcc/x86_64-linux-gnu/13/lto-wrapper ache/go/1.24.12/x64/pkg/tool/linux_amd64/vet -plugin-opt=-pasgit -plugin-opt=-pasrev-parse -plugin-opt=-pasFETCH_HEAD ache/go/1.24.12/x64/pkg/tool/lin-v(dns block)/update-job-proxy /update-job-proxy DROP tnet/tools/git test -e twork_CA_2.pem git /usr/bin/test copilot/fix-comm/usr/lib/git-core/git ux_amd64/vet e/git test -e ification_Authority_ECC.pem e/git(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.
Note
Improves
buzz scheduletimeline wrapping by detecting actual terminal width instead of relying on theCOLUMNSenv var.os.LookupEnv("COLUMNS")withterm.IsTerminal()+term.GetSize()indisplayTimeline(fallback to 80 cols)github.com/charmbracelet/x/termingo.modand import inmain.goImpact: More accurate wrapping in real terminals; piped/non-TTY output remains at 80 columns.
Written by Cursor Bugbot for commit 8b789d6. This will update automatically on new commits. Configure here.