Add a method to publish a plane using the normal and distance#221
Merged
stephanie-eng merged 3 commits intoPickNikRobotics:ros2from May 24, 2022
Merged
Conversation
Author
|
Not sure of the best function name, so if anyone has any better ideas, I'm very open to renaming it. |
Codecov Report
@@ Coverage Diff @@
## ros2 #221 +/- ##
==========================================
- Coverage 19.89% 19.86% -0.04%
==========================================
Files 5 5
Lines 1784 1787 +3
==========================================
Hits 355 355
- Misses 1429 1432 +3
Continue to review full report at Codecov.
|
AndyZe
reviewed
May 24, 2022
4 tasks
Co-authored-by: AndyZe <andyz@utexas.edu>
d4a2682 to
31befd9
Compare
AndyZe
approved these changes
May 24, 2022
Contributor
AndyZe
left a comment
There was a problem hiding this comment.
LGTM. The new variable D could be const (Super nitpick.) Feel free to merge
Co-authored-by: AndyZe <andyz@utexas.edu>
31befd9 to
fc6e9c8
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a convenience method to publish a plane using a normal and an offset