Get and set pretty hostname to use as system name in Web UI#997
Merged
Get and set pretty hostname to use as system name in Web UI#997
Conversation
nucleogenic
reviewed
Nov 19, 2022
nucleogenic
reviewed
Nov 19, 2022
python/web/src/web.py
Outdated
| """ | ||
| Changes the hostname of the system | ||
| """ | ||
| name = request.form.get("system_name") |
Member
There was a problem hiding this comment.
Does this need any validation, e.g. is the downstream command that receives this value OK with untrusted input?
Member
Author
There was a problem hiding this comment.
Good question... hostnamectl seems to be quite forgiving with what can be set as a pretty hostname. Maybe we can set an arbitrary max limit on the str length for starters: something like 120 chars seems to be what would reasonably fit in the UI. An empty string is technically a valid input, since that's how you remove the pretty hostname.
I assume posted form data are always strings, but adding a cast to str could be a minor safeguard just in case.
Any obvious safeguards that I'm missing?
nucleogenic
approved these changes
Nov 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.