Display hardware info in footer; close open file handlers; better error handling#989
Merged
Display hardware info in footer; close open file handlers; better error handling#989
Conversation
akuker
reviewed
Nov 16, 2022
python/common/src/rascsi/sys_cmds.py
Outdated
| except (IOError, ValueError, EOFError, TypeError) as error: | ||
| logging.error(str(error)) | ||
| else: | ||
| hardware = "?" |
Member
There was a problem hiding this comment.
Maybe set this to "Unhandled OS" or something like that?
Member
Author
There was a problem hiding this comment.
Sure, I guess that's more informative.
The reason that I fell back to the question mark is because it's cumbersome to localize strings that come from the common package. You need to pass some kind of token that is then converted to a string in the Flask app. But anyways, it's going to be ultra rare for these fallbacks to be displayed to end users I think, so it's ok to leave them unlocalized probably.
nucleogenic
reviewed
Nov 16, 2022
nucleogenic
reviewed
Nov 16, 2022
nucleogenic
approved these changes
Nov 16, 2022
Member
nucleogenic
left a comment
There was a problem hiding this comment.
Tested in Docker, looks and works well!
|
SonarCloud Quality Gate failed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also improves error handling in get_properties_by_drive_name(), as called out by Sonar.