I did not find apt-install for clang++ in the changes. I don't think it is installed per default, but I'm not sure.

Good catch, I forgot about that. Added now.

@uweseimet I believe clang is a meta package that pulls in the latest stable C, C++, and Obj-C compilers.

$ sudo apt install clang --no-install-recommends
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
The following additional packages will be installed:
  clang-11 libclang-common-11-dev libclang-cpp11 libclang1-11 libllvm11 libobjc-10-dev libz3-4
Suggested packages:
  clang-11-doc
Recommended packages:
  llvm-11-dev libomp-11-dev
The following NEW packages will be installed:
  clang clang-11 libclang-common-11-dev libclang-cpp11 libclang1-11 libllvm11 libobjc-10-dev libz3-4
0 upgraded, 8 newly installed, 0 to remove and 7 not upgraded.
Need to get 37.3 MB of archives.
After this operation, 190 MB of additional disk space will be used.
Do you want to continue? [Y/n]

I don't think I'm on board with having easyinstall install clang. This is going to take extra space and extra time to install it on everyone's raspberry pi, when very very few people are using it.

@uweseimet - is your intention to switch over completely to clang++? If so, then I'm OK with leaving it in. But then I would expect a PR coming to switch the Makefile over.

@akuker As I already mentioned in my ticket, I'm totally fine with rejecting it. This is just a low prioriity suggestion, not more than that.
In general, easyinstall should install only what's needed according to the options the user has selected. If it still installs everything that might potentially be needed I suggest to improve this.

As long as we provide this as "experimental" feature I agree it would make sense to install clang only when explicitly chosen. Save the majority of users the overhead and bloat of having those packags.

I leave the decision to you. I don't have a strong opinion on this. I mainly created this ticket because @akuker mentioned that some users (still) have issues with compiling due to low memory, and I verified that there are no such issues with clang++.

Let's do it! Let's switch to clang :-)

@uweseimet - would you like to update the Makefile? Or should I?

@akuker I suggest we hold off on this PR until the Makefile changes have been made. Do we want to offer gcc as a command line option for easyinstall, e.g. --use-gcc, for users running very old Raspbian versions that might lack a compatible clang compiler?

So since it seems we will need g++ in the Makefile for CI/CD for the time being (more research and testing required) I propose what we do in this PR, is to pivot to clang-11 as the default options in easyinstall and keep gcc in the Makefile. This gives us the benefit of the performance boost for users upgrading their RaSCSI installations, without breaking UTs and static analysis in the short term.

Thoughts?

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

Sounds good to me!