Skip to content

Cleaned up dependencies on controller manager#964

Merged
uweseimet merged 38 commits intodevelopfrom
feature-controller-manager-dependency
Nov 4, 2022
Merged

Cleaned up dependencies on controller manager#964
uweseimet merged 38 commits intodevelopfrom
feature-controller-manager-dependency

Conversation

@uweseimet
Copy link
Copy Markdown
Contributor

@uweseimet uweseimet commented Nov 3, 2022

Main changes:

  • Cleaned up dependencies on controller manager
  • Removed global fields
  • Simplified setting up RascsiResponse and RascsiExecutor
  • Got rid of remaining raw pointers
  • Use references instead of pointers
  • Improved encapsulation

@uweseimet uweseimet linked an issue Nov 3, 2022 that may be closed by this pull request
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Nov 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

74.0% 74.0% Coverage
0.0% 0.0% Duplication

@uweseimet uweseimet marked this pull request as ready for review November 3, 2022 11:44
@uweseimet uweseimet merged commit c98c52f into develop Nov 4, 2022
@uweseimet uweseimet deleted the feature-controller-manager-dependency branch November 4, 2022 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove dependency of host services on controller manager

2 participants