Skip to content

Improved testability of rascsi/rasctl/scsimon/rasdump, eliminated global fields#960

Merged
uweseimet merged 12 commits intodevelopfrom
feature-testability
Nov 2, 2022
Merged

Improved testability of rascsi/rasctl/scsimon/rasdump, eliminated global fields#960
uweseimet merged 12 commits intodevelopfrom
feature-testability

Conversation

@uweseimet
Copy link
Copy Markdown
Contributor

@uweseimet uweseimet commented Nov 2, 2022

Main changes:

  • Improved testability by moving the code from rascsi/rasctl/scsimon/rasdump.pp into classes
  • Removed some global variables
  • Moved bus.h/cpp to hal
  • Code cleanup, especially redundancies
  • Fixed SonarCloud issues

The new code smells are reported for old code, but because of a still unkown reason SonarCloud does not analyze all files.

@uweseimet uweseimet marked this pull request as ready for review November 2, 2022 17:19
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Nov 2, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 19 Code Smells

4.2% 4.2% Coverage
4.3% 4.3% Duplication

Copy link
Copy Markdown
Member

@akuker akuker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@uweseimet - Approved. Thanks!

@uweseimet uweseimet merged commit 83d1595 into develop Nov 2, 2022
@uweseimet uweseimet deleted the feature-testability branch November 2, 2022 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve testability of rascsi.cpp, rasctl.cpp, scsimon.cpp, rasdump.cpp

2 participants