Code cleanup, especially casts, lambdas, data types, encapsulation#952
Code cleanup, especially casts, lambdas, data types, encapsulation#952
Conversation
|
SonarCloud Quality Gate failed. |
|
@uweseimet Please note that branches with the "feature_" naming scheme are treated as long-lived branches in SonarCloud now. If you intended feature_minor_code_cleanup to be long-lived then that's fair game of course! |
|
@rdmark I thought this was only for branches starting with "release-" or "feature-", i.e. with a hyphen and not an underline character. But you are right, I missed that, and it is not intentional that my branches are long-lived branches. Branch names starting with "feature-" are not long-lived, are they? |
|
@uweseimet Correct, branches that begin with "feature-" aren't treated as long-lived. But perhaps they should? In my mind, long lived branches are those that make broad changes or implement a large chunk of new code, and will be iterated on over multiple weeks or longer. Hence, the need for continuous and persistent code quality scanning on them. What do you think is a good branch naming scheme, that covers the various types of development that happen in this project? |
|
@rdmark IMO for rascsi it is sufficient that only develop (besides master) is a long lived branch. For much more than a year (if I remember correctly) there has never been any feature branch that was alive for several weeks. Except for the branches marked as stale in github. I doubt that most of those are still useful. They have not been maintained/changed for ages, and it is unlikely that they can ever be merged into the current codebase after such a long time. Cleaning them up sounds like a good idea to me. |
|
Good to go! Thanks @uweseimet ! |
|
@akuker Thank you for reviewing! |
Some cleanup stuff, mostly based on C++ best practices:
Note that the bugs, security issues and code smells reported are not new code. They have been there before and are part of the bad code in cfilesystem.cpp.