Validate SCSI error codes (sense key, asc) in unit tests (issue #895)#950
Merged
Validate SCSI error codes (sense key, asc) in unit tests (issue #895)#950
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
akuker
reviewed
Oct 29, 2022
| TEST(ScsiControllerTest, MsgOut) | ||
| { | ||
| auto bus = make_shared<MockBus>(); | ||
| auto bus = make_shared<NiceMock<MockBus>>(); |
Member
There was a problem hiding this comment.
@uweseimet - only for my own understanding, what does NiceMock<> do?
Contributor
Author
There was a problem hiding this comment.
@akuker NiceMock suppresses warnings like the one below provided that you definitely know that the warning is irrelevant for your test case. We have some of these scenarios, where the mocks are tailored for testing AbstractController, for instance, but when being used with a different test (where AbstractController is not the object under test but is just needed to set up the object under test) cause lots of these warnings.
GMOCK WARNING:
Uninteresting mock function call - returning directly.
Function call: SetCD(false)
NOTE: You can safely ignore the above warning unless this call should not happen. Do not suppress it by blindly adding an EXPECT_CALL() if you don't mean to enforce the call. See https://github.com/google/googletest/blob/master/docs/gmock_cook_book.md#knowing-when-to-expect for details.
akuker
approved these changes
Oct 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.