SonarCloud Quality Gate failed.   

4 Bugs
0 Vulnerabilities
62 Security Hotspots
171 Code Smells

46.0% Coverage
2.5% Duplication

@rdmark Looks fine for me, but surprisingly on my machine a unit test fails, which does not fail with the develop branch:

[ RUN      ] RascsiImageTest.DeleteImage
rascsi_test: ./devices/storage_device.cpp:64: void StorageDevice::ReserveFile(const std::string &, int, int) const: Assertion `reserved_files.find(file) == reserved_files.end()' failed.
make: *** [Makefile:174: test] Aborted

Your changes are based on develop, aren't they?

@uweseimet Yes, this branch is based on the latest develop. It's odd that a UT would fail for you, I agree. There must be some assumption about the location of code somewhere, I suppose? I've been building the tests in my environments but it takes a long time, since I only have the Pi, and an emulated Linux environment. Both are quite slow.

In my x64 VM with Debian Sid bleeding edge I got 264/264 passing tests.

@rdmark I am going to investigate now what's happening on my machine. Can you please wait with merging until I know more details? It might be required to change something in the offending test.

@rdmark Very strange: When running the tests in my regular enviroment (last time I was using a different folder with a fresh checkout) everything is passing. The tests do no require any special setup, and I have no idea what caused them to fail.
Anyway, things appear to be fine now.

@rdmark Do the tests in RASCS/test/robot still have any relevance?

@rdmark Do the tests in RASCS/test/robot still have any relevance?

@uweseimet I believe these are the tests that run in @akuker's personal lab environment against real hardware

Perhaps we can move them into /hw/test/robot

@rdmark We might address this in a separate step, depending on @akuker's feedback. I would appreciate the current changes to be merged soon, because otherwise it's inconvenient for me to continue with issue 663, which I need to update based on the changes of this PR.

@uweseimet Agreed, there is no rush to clean this up in this PR. All the unit tests passed also on my RPi3+ w/ Bullseye so this is good to go.