Bump to the latest bjoern/Flask/Jinja2 for the Web UI#935
Merged
Conversation
… are implicit dependencies of the above so removing explicit requirements.
|
Kudos, SonarCloud Quality Gate passed!
|
nucleogenic
reviewed
Oct 24, 2022
Member
nucleogenic
left a comment
There was a problem hiding this comment.
Got a failing test... 🤔
test_set_log_level[critical]
http_client = <requests.sessions.Session object at 0x7f954f29edd0>, level = 'critical'
@pytest.mark.parametrize("level", ["trace", "debug", "info", "warn", "err", "critical", "off"])
def test_set_log_level(http_client, level):
response = http_client.post(
"/logs/level",
data={
"level": level,
},
)
import pprint
pprint.pprint(response.json())
response_data = response.json()
assert response.status_code == 200
> assert response_data["status"] == STATUS_SUCCESS
E AssertionError: assert 'error' == 'success'
E - success
E + error
tests/api/test_settings.py:48: AssertionError
------------------------------------------------------------------------------------------------------------------ Captured stdout call ------------------------------------------------------------------------------------------------------------------
{'data': {},
'messages': [{'category': 'error', 'message': 'Invalid log level critical'}],
'status': 'error'}
-------------------------
Member
Author
|
@nucleogenic Interesting! Is 'critical' really a valid log level? From the man page: |
Member
Author
|
@nucleogenic Mystery solved. The critical log level was removed in #915 -- I assume you recompiled rascsi before running these tests! I have another branch in the works for adding some tests. How about I address this log level test there? |
nucleogenic
approved these changes
Oct 24, 2022
Member
nucleogenic
left a comment
There was a problem hiding this comment.
Aha! Yep, no problem with that.
I'm rebuilding RaSCSI in Docker for most branches I pull down:
cd docker
docker compose build --no-cache --progress=plain
docker compose up
docker compose run pytest -v
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
click/itsdangerous/MarkupSafe are implicit dependencies of the above so removing explicit requirements.