Skip to content

Fix logging for Data Out phase, fixed offset#907

Merged
uweseimet merged 3 commits intodevelopfrom
fix_logging_dataout
Oct 11, 2022
Merged

Fix logging for Data Out phase, fixed offset#907
uweseimet merged 3 commits intodevelopfrom
fix_logging_dataout

Conversation

@uweseimet
Copy link
Copy Markdown
Contributor

@uweseimet uweseimet commented Oct 10, 2022

This change reverts a previous change related to logging an unexpected Data Out phase. It's not clear why the re-added cases are needed, but for now (with this PR) the logging behavior is like it was before (i.e. with release 22.08.1 and older).
A wrong offset (caused by a typo) is also fixed.

@uweseimet uweseimet changed the title Fix logging for Data Out phase Fix logging for Data Out phase, fixed offset Oct 10, 2022
@uweseimet
Copy link
Copy Markdown
Contributor Author

@rdmark The offset correction in this PR fixes a regression in the DaynaPort code, which resulted in an assertion being false.
The DaynaPort works fine for me again with this fix, but my test setup for the DaynaPort is not that good. Maybe you can also run a test?

@rdmark
Copy link
Copy Markdown
Member

rdmark commented Oct 10, 2022

@uweseimet Thanks, I will compile and test this on my Macs today.

BTW, we're aiming to tag the next release on 10/15, the upcoming weekend.

@uweseimet
Copy link
Copy Markdown
Contributor Author

@rdmark I thought the next release was targeted for the end of the month and testing would start next eekend? This project tends to become a project with more aggressive release data than commercial projects. What a pity ...

@rdmark
Copy link
Copy Markdown
Member

rdmark commented Oct 10, 2022

@uweseimet In my opinion there is little cost in releasing early. Tagging a release is the primary mechanism we have in this project for getting people to install and test it. We have not had success in the past with calls for pre-release testing. In the worst case, the community finds bugs, and we fix them and roll forward.

What do you think?

@uweseimet
Copy link
Copy Markdown
Contributor Author

uweseimet commented Oct 10, 2022

@rdmark I see, and yes, you may be right. I would like a more predictable release planning, but I agree that from what we learned in the past without a release there won't be much testing (by others).
On the pro side it means that the changes (addressing two existiing tickets) I have prepared in two new branches can probably be merged after next weekend, and will not have to wait till next month ;-).

@rdmark
Copy link
Copy Markdown
Member

rdmark commented Oct 11, 2022

I did a brief test on my Power Mac 8600 and it seems to work fine.

@uweseimet
Copy link
Copy Markdown
Contributor Author

@rdmark Thank you for testing. While testing the host services and printer device I noticed that when the very first command they receive is TEST UNIT READY they return MEDIUM NOT PRESENT: This is wrong, of course, because there is no medium. I just fixed that.

@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@uweseimet uweseimet merged commit dede2a6 into develop Oct 11, 2022
@uweseimet uweseimet deleted the fix_logging_dataout branch October 11, 2022 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants