Fix logging for Data Out phase, fixed offset#907
Conversation
|
@rdmark The offset correction in this PR fixes a regression in the DaynaPort code, which resulted in an assertion being false. |
|
@uweseimet Thanks, I will compile and test this on my Macs today. BTW, we're aiming to tag the next release on 10/15, the upcoming weekend. |
|
@rdmark I thought the next release was targeted for the end of the month and testing would start next eekend? This project tends to become a project with more aggressive release data than commercial projects. What a pity ... |
|
@uweseimet In my opinion there is little cost in releasing early. Tagging a release is the primary mechanism we have in this project for getting people to install and test it. We have not had success in the past with calls for pre-release testing. In the worst case, the community finds bugs, and we fix them and roll forward. What do you think? |
|
@rdmark I see, and yes, you may be right. I would like a more predictable release planning, but I agree that from what we learned in the past without a release there won't be much testing (by others). |
|
I did a brief test on my Power Mac 8600 and it seems to work fine. |
|
@rdmark Thank you for testing. While testing the host services and printer device I noticed that when the very first command they receive is TEST UNIT READY they return MEDIUM NOT PRESENT: This is wrong, of course, because there is no medium. I just fixed that. |
|
Kudos, SonarCloud Quality Gate passed! |








This change reverts a previous change related to logging an unexpected Data Out phase. It's not clear why the re-added cases are needed, but for now (with this PR) the logging behavior is like it was before (i.e. with release 22.08.1 and older).
A wrong offset (caused by a typo) is also fixed.