Skip to content

Refactor python code to address Sonarcloud issues#900

Merged
rdmark merged 23 commits intodevelopfrom
rdmark-refactor-python
Oct 9, 2022
Merged

Refactor python code to address Sonarcloud issues#900
rdmark merged 23 commits intodevelopfrom
rdmark-refactor-python

Conversation

@rdmark
Copy link
Copy Markdown
Member

@rdmark rdmark commented Oct 8, 2022

  • copy/move/delete file class methods now take Path objects as arguments
  • The file download endpoint in the Web UI uses the safer download from dir method
  • Simplified logging
  • Merged nested if statements
  • Removed naked handling of unknown error states
  • Added fallback empty list for drive_properties, to avoid errors when json file is missing or broken
  • Move drive_properties to env[]
  • Constants for common error messages
  • Dummy variable for list comprehension

@rdmark rdmark requested a review from nucleogenic October 8, 2022 21:13
@rdmark rdmark marked this pull request as ready for review October 8, 2022 23:47
@rdmark rdmark requested a review from nucleogenic October 9, 2022 05:25
@rdmark rdmark merged commit 1b10b12 into develop Oct 9, 2022
@rdmark rdmark deleted the rdmark-refactor-python branch October 9, 2022 20:50
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Oct 9, 2022

Please retry analysis of this Pull-Request directly on SonarCloud.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants