Skip to content

Merged FileSupport into Disk, improved granularity, more unit tests, code cleanup#897

Merged
uweseimet merged 47 commits intodevelopfrom
feature_merge_file_support_into_disk
Oct 8, 2022
Merged

Merged FileSupport into Disk, improved granularity, more unit tests, code cleanup#897
uweseimet merged 47 commits intodevelopfrom
feature_merge_file_support_into_disk

Conversation

@uweseimet
Copy link
Copy Markdown
Contributor

@uweseimet uweseimet commented Oct 6, 2022 •
edited
Loading

This is a new attempt to create a proper PR for the original feature_merge_file_support branch, which had strange merging issues.

Most relevant changes:

  • Merged FileSupport into Disk
  • Improved code granularity
  • Made classes previously directly writing to cout testable
  • Added numerous unit tests (total test count is 167)
  • Fixed minor issues uncovered by unit tests
  • Fixed SonarCloud issues
  • Replaced remaining proprietary data types (WORD/DWORD) except for files in hal/
  • Fixed formatting inconsistencies (curly braces)

@uweseimet uweseimet linked an issue Oct 6, 2022 that may be closed by this pull request
Merge FileSupport class with Disk class #674
Closed
@uweseimet uweseimet changed the title Merged FileSupport into Disk, improved granulary, more unit tests, code cleanup Merged FileSupport into Disk, improved granularity, more unit tests, code cleanup Oct 6, 2022
@uweseimet uweseimet marked this pull request as ready for review October 7, 2022 16:07
akuker
akuker requested changes Oct 7, 2022
View reviewed changes
@uweseimet
Copy link
Copy Markdown
Contributor Author

uweseimet commented Oct 8, 2022 •
edited
Loading

@akuker Please note that I added three fixes related to the logging output. I stumbled upon them while testing.
Also fixed an issue caused by Daynaport and the bridge being subclasses of the Disk class even though they are no disks :-(

@akuker
Copy link
Copy Markdown
Member

akuker commented Oct 8, 2022

Approved! Thank you for investigating the strcpy thing!

@uweseimet
Copy link
Copy Markdown
Contributor Author

uweseimet commented Oct 8, 2022

@akuker Thank you for reviewing!

@uweseimet uweseimet merged commit ca23d9b into develop Oct 8, 2022
@uweseimet uweseimet deleted the feature_merge_file_support_into_disk branch October 8, 2022 17:26
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Oct 8, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

53.2% 53.2% Coverage
0.3% 0.3% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akuker akuker akuker approved these changes

@erichelgeson erichelgeson Awaiting requested review from erichelgeson

@rdmark rdmark Awaiting requested review from rdmark rdmark is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Merge FileSupport class with Disk class

2 participants

@uweseimet @akuker