Updated memory management, added unit tests, fixed SonarCloud issues#862
Updated memory management, added unit tests, fixed SonarCloud issues#862
Conversation
|
Thanks @uweseimet !! Just a couple of comments. I know I'm slow, but could you avoid changes to gpiobus for the time being? (unless they're bug fixes) |
|
@akuker Regarding the gpiobus changes, these fix SonarCloud issues. Just a few lines are changed. If this is an issue for you, for this PR we can revert the changes in the 'hal' folder to what we currently have in develop. On the other hand, except for a few more changed lines (currently in the feature_more_unit_tests branch) I am done with updating 'hal'. I just merged these pending changes into the PR for feature_memory_management.
I hope it's clear what I mean :). Of course I prefer option 1, because these changes jsut a few lines and because they have already been tested by @rdmark and me. @akuker Please remember that I would like to merge this PR myself after approval, in order to clean up the merge message. |
|
SonarCloud Quality Gate failed. |
Option 1 is good for me :-) The changes should be easy enough to merge in to my stuff. Have a great weekend! |
|
@akuker Once more, thank you for taking time to review my numerous changes. Have a great weekend as well! |








This PR resolves most of the remaining memory management and structural issues. The vast majority of SonarCloud issues is now caused by the horrible code in filesystem.cpp/h.
Testing was done with my standard hardware setup on buster and bullseye, with gcc and clang, and of course with the extended set of unit tests.
@akuker I would also like to merge this PR myself after approval, in order to provide details in the merge message.