Cleanup (memory management, STL containers, type safety) based on SonarCloud report#845
Merged
Cleanup (memory management, STL containers, type safety) based on SonarCloud report#845
Conversation
nucleogenic
reviewed
Sep 20, 2022
Contributor
Author
|
@akuker I have added all of my pending changes, i.e. this PR is ready for review. |
Member
|
@uweseimet - one minor comment, then it looks ready to merge. |
akuker
requested changes
Sep 20, 2022
|
SonarCloud Quality Gate failed. |
akuker
approved these changes
Sep 20, 2022
Member
|
I'm on my mobile, so I'll let you do the merge, in case something goes wrong. |
Contributor
Author
|
@akuker OK. Thank you for reviewing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.