Memory management update, SonarCloud fixes, fix for issue #841#842
Merged
Memory management update, SonarCloud fixes, fix for issue #841#842
Conversation
Contributor
Author
|
@akuker The Raspian buster compiler complained: IMO the compiler is right (don't know why other compilers don't report it), because if IFNAMSIZE bytes are copied the terminating null byte would be missing. Maybe -Wextra checks for different issues with different gcc versions. We defniitely have to get rid of char arrays in favor of std::string, which is something also reported by SonarCloud. |
|
SonarCloud Quality Gate failed. |
akuker
approved these changes
Sep 15, 2022
Member
|
@uweseimet - looks good. feel free to merge at your discretion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Just for the record: The false positives I mentioned previously are only reported by SonarLint, not by SonarCloud.