Skip to content

Remove file extension validation in upload form#826

Merged
uweseimet merged 2 commits intodevelopfrom
rdmark-upload-validation
Sep 3, 2022
Merged

Remove file extension validation in upload form#826
uweseimet merged 2 commits intodevelopfrom
rdmark-upload-validation

Conversation

@rdmark
Copy link
Copy Markdown
Member

@rdmark rdmark commented Sep 2, 2022

Also: Improve on the related help text. Addresses issue

Copy link
Copy Markdown
Contributor

@uweseimet uweseimet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rdmark There are still many occurences of 'valid_file_suffix' in the python code and the translations. This might be correct, but I would have expected that at least some of would become obsolete with this change.

@rdmark
Copy link
Copy Markdown
Member Author

rdmark commented Sep 2, 2022

@uweseimet That's a good call-out. I believe what we have is still correct. The variable is used to display help text in the Web UI about which file extensions that rascsi considers valid images.

I pushed a small update to split the image and archive file extensions and display them separately in the UI.

@uweseimet uweseimet merged commit 2411afb into develop Sep 3, 2022
@uweseimet uweseimet deleted the rdmark-upload-validation branch September 3, 2022 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants