Conversation
Contributor
|
@akuker Looks fine to me. What was the error about? Anything related to the unused return value of write()? |
uweseimet
approved these changes
Aug 26, 2022
Member
Author
Ya, it was saying the return value of write() wasn't being used. Thank you for taking a look at this! |
Contributor
|
It's good that you stumbled upon this issue, because regardless of the compiler complaining, returning false if there is a length mismatch is correct. Ignoring the write() result was a bug. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this change, I was able to build and run the
feature_google_testtests on Ubuntu 22.@uweseimet - would you be able to look at this? I don't have a way to test the printer functionality currently. But, it looks like a pretty benign change.