Skip to content

Initial unit tests based on GoogleTest and GoogleMock#802

Merged
akuker merged 57 commits intodevelopfrom
feature_google_test
Aug 28, 2022
Merged

Initial unit tests based on GoogleTest and GoogleMock#802
akuker merged 57 commits intodevelopfrom
feature_google_test

Conversation

@uweseimet
Copy link
Copy Markdown
Contributor

See the related ticker for details.

@uweseimet
Copy link
Copy Markdown
Contributor Author

@akuker It would be great if automatic nightly builds were working, because as part of the automation unit tests could be run, and we could eventually have code coverage metrics. There is a ticket for this if I remember correctly. It's exactly the kind of tickets where I think resolving it is more imporant than adding tickets for new features without somebody willing to start working on them.
@rdmark It's your turn now to find a solution for Python unit tests ;-).

@rdmark
Copy link
Copy Markdown
Member

rdmark commented Aug 27, 2022

@rdmark It's your turn now to find a solution for Python unit tests ;-).

Definitely. We have #300 to track it. The way the Web UI is designed, it might make sense to do headless browser testing with protobuf mocks. I have experience with the pytest test runner so unless I find something more modern that's probably what I'll use. Then probably use the Selenium Webdriver library to automate the web front end.

$(BINDIR)/$(SCSIMON): $(OBJ_SCSIMON) | $(BINDIR)
$(CXX) $(CXXFLAGS) -o $@ $(OBJ_SCSIMON) -lpthread

$(BINDIR)/$(RASCSI_TEST): $(OBJ_RASCSI_TEST) | $(BINDIR)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs $(SRC_PROTOBUF) added to the list of dependencies. otherwise, you need to do "make all" before you can "make test"

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, done.

@akuker
Copy link
Copy Markdown
Member

akuker commented Aug 28, 2022

@akuker It would be great if automatic nightly builds were working, because as part of the automation unit tests could be run, and we could eventually have code coverage metrics. There is a ticket for this if I remember correctly. It's exactly the kind of tickets where I think resolving it is more imporant than adding tickets for new features without somebody willing to start working on them.

Agree that getting automated tests going is important. I've been putting my effort towards #335 - both a hardware and software solution. Once this is complete, I'll dive into the automated tests.

Getting the tests to run automatically shouldn't be a big deal, so I'll see if I can sneak that in.

@akuker akuker merged commit 7fc84c4 into develop Aug 28, 2022
@akuker akuker deleted the feature_google_test branch August 28, 2022 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Initial unit tests based on GoogleTest and GoogleMock Testing improvement: Execute SCSI commands without RaSCSI hardware

3 participants