Skip to content

Fixes to README and easyinstall text#787

Merged
akuker merged 3 commits intodevelopfrom
rdmark-docs-fixes
Aug 5, 2022
Merged

Fixes to README and easyinstall text#787
akuker merged 3 commits intodevelopfrom
rdmark-docs-fixes

Conversation

@rdmark
Copy link
Copy Markdown
Member

@rdmark rdmark commented Aug 4, 2022

No description provided.

@rdmark rdmark changed the title Fixes to README and easyinstall contents Fixes to README and easyinstall text Aug 5, 2022
@uweseimet
Copy link
Copy Markdown
Contributor

@rdmark That's not the Gitflow workflow anymore as far as I can tell. I don't think it's a good idea to reinvent the wheel and invent yet another way of versioning, when there are already best practices. IMHO the original text was correct, but when creating the releases the release numbers were wrong and not according to the Gitflow workflow.

@akuker
Copy link
Copy Markdown
Member

akuker commented Aug 5, 2022

As far as I can tell, Gitflow doesn't define what the version numbering should be. Its more how the changes flow between branches.

We have been starting with .1 at the end of the releases as a convention. The last release, I made a bad tag for .1, so I incremented it to .2.

@akuker akuker merged commit 8cd50da into develop Aug 5, 2022
@akuker akuker deleted the rdmark-docs-fixes branch August 5, 2022 14:30
@uweseimet
Copy link
Copy Markdown
Contributor

@akuker I mentioned this because https://datasift.github.io/gitflow/IntroducingGitFlow.html uses 1.0 (not 1.0.0) as the first version, and that's exactly the approach used also for the Linux kernels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants