Merged
Conversation
rdmark
requested changes
Aug 4, 2022
| """Module for mapping between rascsi return codes and translated strings""" | ||
|
|
||
| from rascsi.return_codes import ReturnCodes | ||
| from flask_babel import _, lazy_gettext |
Member
There was a problem hiding this comment.
Unless I'm missing a crucial step here, I think the _ calls are still needed for l10n to work. For testing, I checked out this branch and went through the steps to generate messages.pot and then merge with existing translations. As far as I can tell, gettext/babel are not picking up the strings in this file for translation anymore.
See: https://python-babel.github.io/flask-babel/index.html#translating-applications
Member
Author
There was a problem hiding this comment.
Aha! Yes, that makes total sense. I've reverted the change. Thanks 🙏
6ef1a99 to
bfa25ce
Compare
…rs, formatting to avoid wrapping of messages
bfa25ce to
078d0fc
Compare
rdmark
approved these changes
Aug 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change set was originally on another branch, but I ended up not needing to use
ReturnCodeMapper.Removes redundant calls to_(gettext) wrapping message strings