Skip to content

#782 compiler interprets 08 as octal, which is invalid#784

Merged
uweseimet merged 1 commit intodevelopfrom
akuker_fix782
Aug 2, 2022
Merged

#782 compiler interprets 08 as octal, which is invalid#784
uweseimet merged 1 commit intodevelopfrom
akuker_fix782

Conversation

@akuker
Copy link
Copy Markdown
Member

@akuker akuker commented Aug 2, 2022

No description provided.

@akuker akuker requested a review from erichelgeson as a code owner August 2, 2022 14:27
@akuker akuker mentioned this pull request Aug 2, 2022
Closed
@uweseimet uweseimet merged commit b902ae6 into develop Aug 2, 2022
@uweseimet
Copy link
Copy Markdown
Contributor

uweseimet commented Aug 2, 2022

Just for the record: The compiler worked as required by the standard, the code was wrong.

integer-literal:  
    decimal-literal integer-suffixopt  
    octal-literal integer-suffixopt  
    hexadecimal-literal integer-suffixopt  
decimal-literal:  
    nonzero-digit  
    decimal-literal digit  
octal-literal:  
    0                           <-----
    octal-literal octal-digit

@akuker akuker deleted the akuker_fix782 branch November 24, 2022 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erichelgeson erichelgeson Awaiting requested review from erichelgeson

1 more reviewer

@uweseimet uweseimet uweseimet approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@akuker @uweseimet