Download and cache pip packages as part of easyinstall#779
Merged
Conversation
rdmark
approved these changes
Jul 31, 2022
Member
rdmark
left a comment
There was a problem hiding this comment.
While I'm not familiar with pip caching, some googling suggests that it does indeed cache packages globally unless you use the --no-cache-dir argument.
I ran some tests, doing a few incremental commits that modified requirements.txt. It seems to retain cached packages better with this change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the pre-made RaSCSI disk image is created, it will download all of the pip packages the first time it boots. Especially on a Pi zero, this can take a long time. Several users have thought the web interface was broken because it took so long for it to start up the first time.
This change is an attempt to cache the python packages at install/build time. The expectation is that the venv will be created with the pre-downloaded pip packages.