Add RASCSI host and port arguments to web/start.sh#771
Merged
rdmark merged 3 commits intoPiSCSI:developfrom Jul 26, 2022
Merged
Add RASCSI host and port arguments to web/start.sh#771rdmark merged 3 commits intoPiSCSI:developfrom
rdmark merged 3 commits intoPiSCSI:developfrom
Conversation
nucleogenic
commented
Jul 25, 2022
552db92 to
f2421f2
Compare
rdmark
requested changes
Jul 25, 2022
python/web/start.sh
Outdated
| echo "ERROR: unknown parameter \"$PARAM\"" | ||
| exit 1 | ||
| ;; | ||
| -p | --port) |
Member
There was a problem hiding this comment.
For clarity we should rename the long form for this parameter now, I think. F.e. "--web-port"
python/web/start.sh
Outdated
Comment on lines
+99
to
+104
| --rascsi-host) | ||
| ARG_RASCSI_HOST="--rascsi-host $VALUE" | ||
| ;; | ||
| --rascsi-port) | ||
| ARG_RASCSI_PORT="--rascsi-port $VALUE" | ||
| ;; |
Member
There was a problem hiding this comment.
Please add a one letter parameter for each. Maybe something like -h and -o
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows web/start.sh to accept
--rascsi-hostand--rascsi-portarguments, which are then passed through to web.py.Fixes an issue where web.py errors when the
--rascsi-portargument is specified.