Skip to content

Fix issue 750 (Daynaport problems in develop branch)#754

Merged
uweseimet merged 4 commits intodevelopfrom
fix_issue_750
Apr 26, 2022
Merged

Fix issue 750 (Daynaport problems in develop branch)#754
uweseimet merged 4 commits intodevelopfrom
fix_issue_750

Conversation

@uweseimet
Copy link
Copy Markdown
Contributor

@uweseimet uweseimet commented Apr 26, 2022

@akuker With this fix it should be possible to release 22.04 at last.

@uweseimet uweseimet changed the title Fix issue 750 Fix issue 750 (Daynaport problems in develop branch) Apr 26, 2022
@uweseimet uweseimet linked an issue Apr 26, 2022 that may be closed by this pull request
@uweseimet uweseimet requested a review from rdmark April 26, 2022 18:16
@uweseimet
Copy link
Copy Markdown
Contributor Author

@rdmark Maybe you can approve, because you are also one of the testers for this issue.

@rdmark
Copy link
Copy Markdown
Member

rdmark commented Apr 26, 2022

@uweseimet Approved. LGTM. The one thing we should test is compatibility with the Atari ST drivers, I think.

@uweseimet
Copy link
Copy Markdown
Contributor Author

uweseimet commented Apr 26, 2022

@rdmark It's unlikely that a driver fails only because it is possible to not only request 36 but also 37 bytes. But on the other hand, you never know :). Effectively the only difference to the last release should be the fact that the additional length field now says 0x20 instead of 0x1f.
@mzryz, can you please run a quick test with the fix_issue_750 branch on the Atari? If it does not work (very unexpected), please also test the current develop branch.

@mzryz
Copy link
Copy Markdown

mzryz commented Apr 26, 2022

@rdmark It's unlikely that a driver fails only because it is possible to not only request 36 but also 37 bytes. But on the other hand, you never know :). Effectively the only difference to the last release should be the fact that the additional length field now says 0x20 instead of 0x1f. @mzryz, can you please run a quick test with the fix_issue_750 branch on the Atari? If it does not work (very unexpected), please also test the current develop branch.

@uweseimet I have compiled and tested this on Atari and everything seems fine.

@uweseimet
Copy link
Copy Markdown
Contributor Author

@mzryz Cool, thank you!

@uweseimet uweseimet merged commit a3a5335 into develop Apr 26, 2022
@uweseimet uweseimet deleted the fix_issue_750 branch April 26, 2022 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DaynaPort interface not recognized on Mac Plus on "develop" branch

3 participants