8bit encoder detection + debounced button detection, numpy removal#710
Merged
8bit encoder detection + debounced button detection, numpy removal#710
Conversation
akuker
approved these changes
Mar 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to my tests, this rewritten rotary encoder detection works quite a bit better than before, especially with different encoder models. The old one worked fine with my bourns encoder, but jumped around with the cheap chinese encoders I had. I have also added a debounce timer for the button presses as it started to jump around a bit with the restructuring done in this change. Very fast movements still do not always get detected, but I think this is due to missing events due to i2c + multiplexer. Also, I have removed numpy. It didn't seem to make any difference any more.