Skip to content

Inquire the backend for device capabilities instead of Web UI assumptions#688

Merged
rdmark merged 13 commits intodevelopfrom
rdmark-backend-device-capabilities
Feb 21, 2022
Merged

Inquire the backend for device capabilities instead of Web UI assumptions#688
rdmark merged 13 commits intodevelopfrom
rdmark-backend-device-capabilities

Conversation

@rdmark
Copy link
Copy Markdown
Member

@rdmark rdmark commented Feb 21, 2022 •
edited
Loading

  • Introduce RaCtlCmds class methods for getting lists of device types, and their capabilities, instead of hard coded constants in common_settings.py
  • Use device capabilities logic across the Web Interface and OLED script, removing hard coded assumptions
  • Introduce a get_device_name() method for mapping human readable device names, and use it in the Web Interface for device attachment messages
  • Use jinja2 sort filters instead of python logic
  • Refactoring

@rdmark
Add capabilities to RaCtlCmds.get_device_types() to return the image …
b58fdd8 
…file support boolean, and list of supported block sizes.
@rdmark
Inquire rascsi backend about the min block size rather than hard codi…
a77a52c 
…ng values in the web UI.
@rdmark
Add class methods for getting lists of certain device types.
858427e
@rdmark
Use the new class methods to get lists of device types in the web ui.
4b42d9a
@rdmark
Make use of the new class methods in the oled script.
c7b3eca
@rdmark
Remove now unused constants, and simplify logic in common_settings
18b20a0
@rdmark
Improve device name mapping to extend the existing dictionary rather …
fe0919c 
…than creating a new data structure.
@rdmark
Use jinja2 sort filters instead of sorting in python code. Removing r…
697e491 
…edundant variables.
@rdmark
Introduce the get_device_name() utility method which returns the tran…
4c15905 
…slated name for a device acronym. Use the new method to display device name when attaching devices.
@rdmark rdmark requested review from bzeiss and uweseimet February 21, 2022 03:05
@rdmark rdmark merged commit 4252d46 into develop Feb 21, 2022
@rdmark rdmark deleted the rdmark-backend-device-capabilities branch February 21, 2022 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akuker akuker Awaiting requested review from akuker akuker is a code owner

@erichelgeson erichelgeson Awaiting requested review from erichelgeson

@bzeiss bzeiss Awaiting requested review from bzeiss

1 more reviewer

@uweseimet uweseimet uweseimet approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rdmark @uweseimet