Initial version of the Control Board UI#687
Merged
Conversation
…tions parameter + autodetection in start.sh. Formatting fixes. #382
…into feature/ctrlboard
rdmark
requested changes
Feb 22, 2022
rdmark
reviewed
Feb 22, 2022
Collaborator
Author
rdmark
approved these changes
Feb 23, 2022
Member
There was a problem hiding this comment.
Overall really cleanly designed codebase, super slick object oriented design. 👍
To be honest, I didn't evaluate all of the internal logic of all of the classes in depth. I also did not test the functionality, since I don't have the requisite hardware. This approval is on the basis of a high-level read of the codebase, and that I could confirm it has no averse effect on existing packages.
Feel free to put any final touches, and merge when you're ready.
Collaborator
Author
|
@akuker Do you want to give this a test drive before I merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the pull request for the initial version of the Control Board UI. It is mostly self-contained in python/ctrlboard and added as experimental feature as installation point 13) in easyinstall.sh. The installation behavior is that selection of ctrlboard ui disables the rascsi-oled service and vice versa. If 1) is selected (rascsi+web), then the enabled service is updated.
https://github.com/akuker/RASCSI/wiki/RaSCSI-Control-Board
(I'm updating this wiki page further after creating the pull request)
I hope you enjoy this :-)