Skip to content

Added filename placeholder, execute print command as lp, fixed memory leaks#677

Merged
rdmark merged 19 commits intodevelopfrom
feature_printer_improvements
Feb 18, 2022
Merged

Added filename placeholder, execute print command as lp, fixed memory leaks#677
rdmark merged 19 commits intodevelopfrom
feature_printer_improvements

Conversation

@uweseimet
Copy link
Copy Markdown
Contributor

@uweseimet uweseimet commented Feb 17, 2022 •
edited
Loading

  • In order for the print command to be more flexible, the default command is going to be "lp -oraw %f" instead of "lp -oraw", with "%f" being a placeholder for the internally generated filename.
  • The print command is not executed by root, but by the lp user.

@uweseimet uweseimet requested a review from rdmark February 17, 2022 14:38
@uweseimet uweseimet mentioned this pull request Feb 17, 2022
Merged
@uweseimet uweseimet changed the title Added filename placeholder for print command Added filename placeholder, execute print command as lp Feb 17, 2022
@uweseimet uweseimet marked this pull request as ready for review February 17, 2022 15:08
@uweseimet uweseimet changed the title Added filename placeholder, execute print command as lp Added filename placeholder, execute print command as lp, fixed memory leaks Feb 18, 2022
@rdmark rdmark merged commit 81ca3c0 into develop Feb 18, 2022
@rdmark rdmark deleted the feature_printer_improvements branch February 18, 2022 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rdmark rdmark rdmark approved these changes

@akuker akuker Awaiting requested review from akuker akuker is a code owner

@erichelgeson erichelgeson Awaiting requested review from erichelgeson

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@uweseimet @rdmark