Proper cleanup of old python protobuf libraries.#667
Merged
Conversation
Member
rdmark
commented
Feb 13, 2022
- Fix issue where the location of the protobuf library in the common package was incorrect
- Clean-up of the old locations of the protobuf library for web and oled. I found out the hard way that if a source file of the same name resides next to the python script being executed, it takes precedence over the one in the common package, which leads to errors when the proto interface changes.
Collaborator
|
@rdmark True, I missed that this is necessary. |
bzeiss
approved these changes
Feb 14, 2022
Collaborator
bzeiss
left a comment
There was a problem hiding this comment.
Straight-forward and looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.