Further improve the dynamic device info web UI by rdmark · Pull Request #657 · PiSCSI/piscsi

rdmark · 2022-02-08T03:08:04Z

Extend the image_files data structure with the human-readable device name once, instead of having complex for loops in the jinja2 template (lower space and time complexity?)
Return a dict instead of list of dicts from extend_device_names() for easier lookup
Define NETWORK_DEVICE_TYPES global constant and use it across the codebase
Generate the list of network devices than can be attached based on NETWORK_DEVICE_TYPES

…, instead of having complex for loops in the jinja2 template.

…ammatically

rdmark added 3 commits February 7, 2022 18:21

Improve the device type selection UI

c5d45ca

Extend the image_files data structure with human readable device name…

e62b7bd

…, instead of having complex for loops in the jinja2 template.

Leverage device type constants in the OLED monitor script

ee2bfda

rdmark requested review from akuker and erichelgeson as code owners February 8, 2022 03:08

Fix typo

c691306

rdmark requested a review from bzeiss February 8, 2022 04:05

rdmark added 2 commits February 8, 2022 00:09

Generate the list of valid network devices that can be attached progr…

2f68e26

…ammatically

Fix typo

ca3a95d

akuker approved these changes Feb 13, 2022

View reviewed changes

akuker merged commit 25b9b4a into develop Feb 13, 2022

akuker deleted the rdmark-dynamic-device-info-tweaks branch February 13, 2022 16:28

Provide feedback